[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] 'svn st --ignore-prop' (was Re: Proposal: --no-props switch for 'log', 'st' and 'diff')

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Thu, 04 Sep 2008 15:35:58 +0100

On Thu, 2008-09-04 at 15:06 +0100, Julian Foad wrote:
> On Thu, 2008-09-04 at 08:55 -0500, Hyrum K. Wright wrote:
> > Hyrum K. Wright wrote:
> > > I'm currently investigating a generic '--ignore-prop' switch, initially for 'svn
> > > st'. It is being written in such a way that we could easily alias
> > > '--ignore-mergeinfo' or '--forget-merges' or
> > > '--dont-get-in-my-way-i'm-trying-to-do-real-work' to mean '--ignore-prop
> > > svn:mergeinfo'. I hope to have a proof-of-concept patch done in a few days.
> >
> > As promised, here's a patch which implements the above. It completely
> > implements the functionality which it claims to, but there is still future work
> > to be done to flesh out the feature. This does not add a '--ignore-mergeinfo'
> > alias as discussed above, but adding such would be trivial.
> >
> > I'd appreciate any feedback, but if there aren't serious objections, I'll commit
> > the patch in the next day or two.
> >
> > [[[
> > Add support for ignoring arbitrary property modifications in 'svn st'.
> > This currently only works locally, not with 'svn st -u'.
> We should always be cautious about complexifying libsvn_wc. Can I ask
> whether and why it is beneficial to add this complexity into libsvn_wc
> rather than filtering at the presentation layer?

Starting to answer my own question:

The client side of a status query doesn't receive a list of the property
changes, just the flag saying "props are changed". Therefore no way to
filter on the client side, using the present API.

However, there's a concept mis-match going on. The WC has the concept of
properties; it has the concept of properties that are special to
Subversion ("svn:*"), and rules on how to treat them. Now we're wanting
a concept of "properties whose changes we don't want to see in the
UI"... huh, but obviously the place to implement that is in the UI code.

The problem is there isn't a convenient API to tell the UI what all the
prop changes in the WC are. Let's design one.

- Julian

To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-04 16:36:18 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.