[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Subversion sometimes needlessly asks for confirmation to store already stored plaintext passwords

From: Senthil Kumaran S <senthil_at_collab.net>
Date: Thu, 04 Sep 2008 00:51:50 +0530

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Karl Fogel wrote:
> I like the log message -- it explains the core meaning of the change
> very clearly.

The credits goes to stsp :) (http://svn.haxx.se/dev/archive-2008-07/0541.shtml).

> This conditional structure is a bit odd, because you check 'err' (the
> pointer) after clearing 'err' (the value).
>
> Usually we set errors to NULL after clearing them, so that we're not
> keeping a pointer that points to garbage. Thus, it would be better to
> do something like this:
>
> err = svn_config_read_auth_data(&creds_hash, SVN_AUTH_CRED_SIMPLE,
> realmstring, config_dir, pool);
> if (err)
> {
> svn_error_clear(err);
> err = NULL;
> }
> else if (creds_hash)
> {
> /* We have something in the auth cache for this realm. */
> [...]
> }
>
> Rest looks good to me!

I ve made the above modification and committed in r32874.

Thank You.
- --
Senthil Kumaran S
http://www.stylesen.org/

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIvuPM9o1G+2zNQDgRAuBAAKC+j7+RzgdTj83E+mBXwU0jU/M+MwCgp5pl
ubG8ULTPGqKL+/nwCRJvaic=
=qFTR
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-03 21:22:13 CEST

This is an archived mail posted to the Subversion Dev mailing list.