[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Difference of behavior between svn 1.4.5 and 1.5.1 for svnlook diff

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Tue, 2 Sep 2008 20:46:01 +0300 (Jerusalem Daylight Time)

Forward to list.

Frederic Melot wrote on Tue, 2 Sep 2008 at 09:38 +0200:
> Hello,
>
> do you know if this behavior will be corrected in a future svn release and on
> which one ?
>

I don't know when it will be fixed. (It should be fixed, since it's a
regression.) No one stepped up yet to fix it; feel free to do it
yourself, though. See HACKING, particularly [1].

Once committed, the fix is likely to be backported to the 1.5.x line and
be included in the next release.

Daniel

[1] http://subersion.tigris.org/hacking.html#patches

> Best regards,
> Frédéric
>
> Daniel Shahaf wrote:
> > C. Michael Pilato wrote on Thu, 28 Aug 2008 at 10:13 -0400:
> >
> > > Looks like in the original recipe, the copied thing was a directory
> > > (copied
> > > from "trunk"). Is that significant?
> > >
> > >
> >
> > Yes. (Julian pointed out the same.)
> >
> > % /usr/bin/svnlook diff -r2 r1
> > Copied: trunk2 (from rev 1, trunk)
> >
> > % svnlook diff -r2 r1
> >
> > %
> >
> > In 1.4, it just prints the "Copied" header immediately:
> >
> > SVN_ERR(svn_cmdline_printf(pool, _("Copied: %s (from rev %ld, %s)\n"),
> > path, node->copyfrom_rev, base_path));
> > printed_header = TRUE;
> >
> > but in trunk, it uses a buffer:
> >
> > svn_stringbuf_appendcstr
> > (header,
> > apr_psprintf(pool, _("Copied: %s (from rev %ld, %s)\n"),
> > path, node->copyfrom_rev, base_path));
> >
> > And, apparently, never prints its contents for the directory case...
> >
> > Daniel
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-02 19:46:44 CEST

This is an archived mail posted to the Subversion Dev mailing list.