Re: svn commit: r32829 - in trunk/subversion: libsvn_subr libsvn_wc svn svnadmin svndumpfilter tests/libsvn_diff tests/libsvn_subr

Arfrever Frehtes Taifersar Arahesis wrote:
> 2008-08-30 16:14:47 Hyrum K. Wright napisał(a):
>> arfrever_at_tigris.org wrote:
>>> Author: arfrever
>>> Date: Sat Aug 30 06:54:54 2008
>>> New Revision: 32829
>>>
>>> Log:
>>> Use svn_stringbuf_from_file2() instead of deprecated svn_stringbuf_from_file().
>>>
>>> * subversion/libsvn_subr/subst.c:
>>> * subversion/libsvn_wc/adm_files.c:
>>> * subversion/svnadmin/main.c:
>>> * subversion/svn/conflict-callbacks.c:
>>> * subversion/svndumpfilter/main.c:
>>> * subversion/svn/main.c:
>>> * subversion/svn/util.c:
>>> * subversion/tests/libsvn_diff/diff-diff3-test.c:
>>> * subversion/tests/libsvn_subr/string-test.c:
>>> * subversion/tests/libsvn_subr/translate-test.c:
>>> Use svn_stringbuf_from_file2() instead of deprecated svn_stringbuf_from_file().
>> I'm concerned about modifying the tests to remove the use of deprecated
>> functionality. The tests exist, in part, to test that functionality, and make
>> sure that any reimplementation continue to maintain the prior functionality.
>>
>> Please revert the changes to the tests in this revision, and in r32830.
>
> I reverted these changes in r32832.
>
>> Perhaps we can define SVN_DEPRECATED at the beginning of the test files so
>> that they don't compile with the warning?
>
> OK. I will check what can be done.

Thanks!

-Hyrum