"Rui, Guo" <timmyguo_at_mail.ustc.edu.cn> writes:
>> Regarding the "log_number = 0" thing:
>>
>> The log_number parameter to do_entry_deletion() was not documented (in
>> fact, the entire function was not documented). I made an attempt to
>> document it in r32516. Then I looked more carefully at the log message
>> for r9868, where that parameter was introduced, and got a better idea of
>> what log_number is for; now I'm not sure it's safe for us to just write
>> "log_number = 0" there, unless we're sure that no other log files are in
>> use right now. Are we sure of that?
>
> I admit that I copied this line from somewhere else and did not dig into the
> meanning of 'log_number'. Do you have any suggestion on this potential
> problem?
I believe it is safe, because no log files could be pending when we
reach that code. (Is that right?)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-28 19:22:45 CEST