[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Difference of behavior between svn 1.4.5 and 1.5.1 for svnlook diff

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Thu, 28 Aug 2008 18:04:07 +0300 (IDT)

C. Michael Pilato wrote on Thu, 28 Aug 2008 at 10:13 -0400:
> Looks like in the original recipe, the copied thing was a directory (copied
> from "trunk"). Is that significant?
>

Yes. (Julian pointed out the same.)

        % /usr/bin/svnlook diff -r2 r1
        Copied: trunk2 (from rev 1, trunk)

        % svnlook diff -r2 r1

        %

In 1.4, it just prints the "Copied" header immediately:

      SVN_ERR(svn_cmdline_printf(pool, _("Copied: %s (from rev %ld, %s)\n"),
                                 path, node->copyfrom_rev, base_path));
      printed_header = TRUE;

but in trunk, it uses a buffer:

      svn_stringbuf_appendcstr
        (header,
         apr_psprintf(pool, _("Copied: %s (from rev %ld, %s)\n"),
                      path, node->copyfrom_rev, base_path));

And, apparently, never prints its contents for the directory case...

Daniel

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-28 17:03:15 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.