Re: Subversion sometimes needlessly asks for confirmation to store already stored plaintext passwords

Senthil Kumaran S <senthil_at_collab.net> writes:
> + svn_boolean_t need_to_save = FALSE; /* Check if we need to save CREDS. */

Well, this just repeats what the name says :-). When I said "document
the semantics", what I really meant was a general explanation of when
the variable is true and when it's false -- in other words, what the
variable means in practice.

You actually do this later, in a comment near one assignment of the
variable:

+ /* Nothing was present in the auth cache, so indicate that these
+ credentials should be saved if saving is allowed by the run-time
+ configuration. */

I'm just saying that it would be a bit better if that kind of
explanation were collected at the variable's declaration, so the reader
could understand the full semantics from the start -- instead of having
to collect the information bit by bit from reading through the code.
It's not a big deal, though; I think it's pretty clear as-is.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-27 21:34:09 CEST