[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: copy repo->wc segmentation fault

From: <alan.wood_at_clear.net.nz>
Date: Sat, 23 Aug 2008 13:59:15 +1200

I was doing the debugging in MS Visual studio 2005 for the windows side. I can't see
anything really useful to send you from there.
Here is a copy from the stack frame window:
        svn.exe!repos_to_wc_copy_single(svn_client__copy_pair_t *
pair=0x00294458, int same_repositories=1, svn_ra_session_t *
ra_session=0x00294580, svn_wc_adm_access_t * adm_access=0x002dbc98,
svn_client_ctx_t * ctx=0x00272b48, apr_pool_t * pool=0x0029b480)
Line 1460
         svn.exe!repos_to_wc_copy(const apr_array_header_t *
copy_pairs=0x00294438, int make_parents=0, svn_client_ctx_t *
ctx=0x00272b48, apr_pool_t * pool=0x00294400) Line 1677
         svn.exe!setup_copy(svn_commit_info_t * *
commit_info_p=0x0012f8f0, const apr_array_header_t *
sources=0x00293c28, const char * dst_path_in=0x00293c18, int
is_move=0, int force=1, int make_parents=0, const apr_hash_t *
revprop_table=0x00000000, svn_client_ctx_t * ctx=0x00272b48,
apr_pool_t * pool=0x00294400) Line 1944
         svn.exe!svn_client_copy4(svn_commit_info_t * *
commit_info_p=0x0012fa80, apr_array_header_t * sources=0x00293c28,
const char * dst_path=0x00293c18, int copy_as_child=1, int
make_parents=0, const apr_hash_t * revprop_table=0x00000000,
svn_client_ctx_t * ctx=0x00272b48, apr_pool_t * pool=0x002720c0)
Line 1983
         svn.exe!svn_cl__copy(apr_getopt_t * os=0x00272260, void *
baton=0x0012fd94, apr_pool_t * pool=0x002720c0) Line 136
         svn.exe!main(int argc=4, const char * * argv=0x00263940) Line
2018

I can print any detail from variables if you want, but it might be easier to check in a
familiar environment.

Alan

On 22 Aug 2008 at 16:13, Blair Zajac wrote:

> Can you send us a stack trace?
>
> Regards,
> Blair
>
> alan.wood_at_clear.net.nz wrote:
> > I have just traced a bug in the "svn copy URL_at_rev file" command.
> > While following instructions in the svn-book to retrieve a deleted file
> > svn copy svn://fred.ncs.local/ncs/truck/.../a.txt_at_211 a.txt
> > <segmentation fault>
> > This occurred on a Linux machine.
> > I repeated the command from windows command line with the same result.
> >
> > tested on svn version 1.5.1(Linux and win32) and 1.5.x branch(win32)
> >
> > I have traced this through to libsvn_client: copy.c line 1455
> >
> > The return from svn_wc_add_repos_file2() is not checked with SVN_ERR().
> >
> > This fails when the repository name does not exactly match the
> > repository name on the command line.
> > In my case the Linux attempt was different as I used the machines
> > actual name "fred" as opposed to "subversion.ncs.local" which the
> > working copy was built from. On the win32 case I was using a
> > file:///c:/... on the command line, but the working copy was checked
> > out by TortoiseSVN and had file:///C:/... in the working copy.
> >
> > The segmentation fault actually occurs a few lines down when calling
> > extend_wc_mergeinfo() with dst_entry==NULL.
> >
> > After changing to catch the error from the svn_wc_add_repos_file2()
> > I do get an error message about the repositories having different
> > roots which with careful inspection of C vs c may help the user to
> > get it right next time. Would be nicer to to check the repository by
> > uuid rather than name, then check the path within the repository as
> > a string. Or maybe I missed something completely.
> >
> > Thanks for a great product.
> >
> > Alan Wood
> > Napier
> > New Zealand.
Received on 2008-08-23 05:33:08 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.