[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r32628 - trunk/subversion/tests/libsvn_fs

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Fri, 22 Aug 2008 16:55:08 -0700

Karl Fogel wrote:
> "Greg Stein" <gstein_at_gmail.com> writes:
>> On Thu, Aug 21, 2008 at 4:44 PM, <hwright_at_tigris.org> wrote:
>>> +++ trunk/subversion/tests/libsvn_fs/fs-test.c Thu Aug 21 16:44:23 2008 (r32628)
>>> ...
>>> @@ -4383,8 +4383,7 @@ verify_checksum(const char **msg,
>>> svn_fs_txn_t *txn;
>>> svn_fs_root_t *txn_root;
>>> svn_stringbuf_t *str;
>>> - unsigned char expected_digest[APR_MD5_DIGESTSIZE];
>>> - unsigned char actual_digest[APR_MD5_DIGESTSIZE];
>>> + svn_checksum_t *expected_checksum, *actual_checksum;
>> It is highly preferred to have one symbol declaration per line.
> Not sure we've been following that consistently (also not sure everyone
> would agree...) I leave it to you two to settle :-).

I'm easy either way. As a general rule, I try to keep symbols declarations on
separate lines, but in cases like this where there is tight coupling between the
two I'm not as strict. There are *many* places where were we have multiple
symbols defined together, and I'm hesitant to define a hard rule for reasons
Karl mentions elsethread. In this case, I don't think I'll change it, but
you're free to if it is too bothersome. :)


Received on 2008-08-23 01:55:26 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.