[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r32628 - trunk/subversion/tests/libsvn_fs

From: Greg Stein <gstein_at_gmail.com>
Date: Fri, 22 Aug 2008 16:24:48 -0700

Yah. I looked briefly in the hacking guide. Not sure it ever made it
there, but I think I recall discussing it with sussman, and he agreed.

The reason that I prefer it is:

const char *var1, **var2;

It is sometimes difficult to see that var2 is different. One per line
tends to make stuff like the above clearer.

Cheers,
-g

On Fri, Aug 22, 2008 at 4:18 PM, Karl Fogel <kfogel_at_red-bean.com> wrote:
> "Greg Stein" <gstein_at_gmail.com> writes:
>> On Thu, Aug 21, 2008 at 4:44 PM, <hwright_at_tigris.org> wrote:
>>> +++ trunk/subversion/tests/libsvn_fs/fs-test.c Thu Aug 21 16:44:23 2008 (r32628)
>>>...
>>> @@ -4383,8 +4383,7 @@ verify_checksum(const char **msg,
>>> svn_fs_txn_t *txn;
>>> svn_fs_root_t *txn_root;
>>> svn_stringbuf_t *str;
>>> - unsigned char expected_digest[APR_MD5_DIGESTSIZE];
>>> - unsigned char actual_digest[APR_MD5_DIGESTSIZE];
>>> + svn_checksum_t *expected_checksum, *actual_checksum;
>>
>> It is highly preferred to have one symbol declaration per line.
>
> Not sure we've been following that consistently (also not sure everyone
> would agree...) I leave it to you two to settle :-).
>
> -Karl
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-23 01:25:02 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.