[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: The "merge path kludge" in merge_tests.py

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Wed, 20 Aug 2008 16:05:02 -0400

Julian Foad <julianfoad_at_btopenworld.com> writes:
> Julian Foad wrote:
>> Does anyone know a reason not to remove all of this kludge?
> Here is a patch you can test with, especially if you run your tests with
> a RAM disk or other file system, or if your CWD is read-only when
> starting an individual test.
> If merge_tests.py 1 through 50 still pass with this demo (which disables
> the kludge in those tests), then the principle is validated.
> Let us know whether it's OK!

I think I've had a TODO item for, like, two years to check and see if
that kludge is still necessary (I also suspect it's not). If your patch
passes, +1 on getting rid of that thing. The code will get much
cleaner, although, of course, that will be some effort, since many of
the tests chdir and whatnot to cooperate with the kludge.

To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-20 22:05:38 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.