Re: [RFC] Mark deprecated functions with SVN_DEPRECATED / __attribute__((deprecated))

2008-08-19 14:10:19 Julian Foad napisaƂ(a):
> On Tue, 2008-08-19 at 13:14 +0200, Arfrever Frehtes Taifersar Arahesis
> wrote:
> > 2008-08-18 23:25:34 Greg Stein napisał(a):
> > > Well, by definition, we don't need the developer to upgrade their
> > > software. They should be able to freely use the old API with no
> > > consequences. Thus, there is no rational reason for us to spam them.
> >
> > Such messages shouldn't be treated as spam. They would be seen mostly only
> > by developers of software which uses Subversion libraries. People who don't
> > like warnings can use the '-w' compiler option.
>
> No. Greg is right. If a developer upgrades their version of Subversion,
> and then sees lots of new warnings that they can't turn off
> independently of other warnings, that would be spam.

OK. We can define SVN_DEPRECATED only if it isn't already defined:

#ifndef SVN_DEPRECATED
#if defined(__GNUC__)
#define SVN_DEPRECATED __attribute__((deprecated))
#elif defined(_MSC_VER) && _MSC_VER >= 1300
#define SVN_DEPRECATED __declspec(deprecated)
#else
#define SVN_DEPRECATED
#endif
#endif

Then developers can use the -DSVN_DEPRECATED="" compiler option to disable
deprecation warnings.

-- 
Arfrever Frehtes Taifersar Arahesis