Memory leak in svn_ra_local__get_file() for symlinks

Hello everybody,

I found a (kind of) memory leak in svn_ra_get_file() for file://-urls, with
1.5.1 libraries, reproduceable with "svn cat", too.

It shows as an allocation of about 500kB for this call; for a svn+ssh:// url
it's only about 26k.

Reproduction recipe (with plain binaries, without symbols):
* a fsfs repository, accessible via file://, with a symlink in it
  (in my tests in /trunk/subdir/symlink), with data of about 60 bytes.
* svn_ra_get_file(); for me into a svn_stringbuf_t, but a plain
  "svn cat" (which does stream to disk, I think) shows that too.
* "gdb --args svn cat file:///repos/path/trunk/dir/symlink"
* Set a breakpoint on "svn_ra_get_file()"
* Start the svn process
* When the breakpoint is hit, look at the process' size
* Continue this function with "n"; gdb stops at the end
* Look at the size again - +500kB.

That's on debian, i686; if you need any more details just ask.

I "fixed" that by creating a new child pool, and destroying that directly
after the svn_ra_get_file() - but needing ~500kB for 80 byte data is a bit
much, isn't it?

Regards,

Phil

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-19 08:08:46 CEST