Re: [PATCH] Fix issue #3239

Hi,

I would like to get some review on this patch, so that it could be backported
to issue2489 branch.

Thank You.

Senthil Kumaran S wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi Karl,
>
> Karl Fogel wrote:
>> Actually, I think this brings the code into compliance with this API:
>>
>> typedef struct svn_auth_cred_ssl_client_cert_t
>> {
>> /** Full paths to the certificate file */
>> const char *cert_file;
>> /** Indicates if the credentials may be saved (to disk). For example, a
>> * GUI prompt implementation with a remember certificate checkbox shall
>> * set @a may_save to TRUE if the checkbox is checked.
>> */
>> svn_boolean_t may_save;
>> } svn_auth_cred_ssl_client_cert_t;
>>
>> Since svn_cmdline_auth_ssl_client_cert_prompt() just sets the
>> 'cert_file' field in *cred, and that is documented to be the "full
>> paths", there is no incompatibility here. This can be considered a
>> bugfix, really.
>
> As per your comments I am attaching an updated patch.
>
> [[[
> Fix issue #3239 - client cert passphrase cache keyed by relative path,
> not absolute path
>
> * subversion/libsvn_subr/prompt.c
> (svn_cmdline_auth_ssl_client_cert_prompt): Get the absolute path of cert
> file and set it in the credentials.
>
> * subversion/include/svn_cmdline.h
> (svn_cmdline_auth_ssl_client_cert_prompt): Document that an absolute path
> of SSL client certificate filename will be recorded.
>
> * subversion/include/svn_auth.h
> (svn_auth_cred_ssl_client_cert_t): In the documentation
> s/Full paths/Absolute path/
>
> Patch by: stylesen
> ]]]
>
> Thank You.
> - --
> Senthil Kumaran S
> http://www.stylesen.org/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
>
> iD8DBQFIht4z9o1G+2zNQDgRAhhmAKCUgVRI7hdUve7Q83V2++X7XSqKAwCfc8TH
> dNSXtP5Nts+hHjXFp3wFK7g=
> =fsWK
> -----END PGP SIGNATURE-----
>
>
> ------------------------------------------------------------------------
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
> For additional commands, e-mail: dev-help_at_subversion.tigris.org

-- 
Senthil Kumaran S
http://www.stylesen.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org