[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: tree-conflicts: patch for improved cmdline tests

From: Stefan Sperling <stsp_at_elego.de>
Date: Sun, 17 Aug 2008 15:22:11 +0200

On Sun, Aug 17, 2008 at 02:36:48PM +0200, Neels Janosch Hofmeyr wrote:
> Currently, most of these new tests still yield undesirable results. The
> course that I aim for is this:
> 1) Commit the new tree-conflicts tests, so that they PASS the current
> tree-conflicts branch, even though many test results are still
> undesirable. (This patch)

Hey Neels,

note that there's also XFail(), which can be used to mark
tests which are expected to fail.

In this case, almost every test would need to be flagged XFail.
However, migrating tests from XFail to PASS by changing Subversion's
code only might be less confusing than migrating tests from PASS
to PASS by changing both Subversion's code and the test in the same go.

The net result is the same.

But I assume that we don't really know yet what the desired
result actually is for many cases, right? :)

> 2) One by one, look at the undesirable results and fix them in subsequent
> patches. Patches should both fix the situation and make the tests
> pass the fixed situation.

Maybe make that 3 steps?

1) Have tons of tests that PASS the current state of things (this patch)

for test in tests:
  2) Figure out what the desired result for $test should be,
     make $test check for that and mark it XFail.
  3) Implement desired behaviour in Subversion's code, making
     $test PASS, and remove its XFail status.

> So, as mentioned, this patch passes the current situation on the
> tree-conflicts branch. But, one test case cannot be passed, because it fails
> in a segmentation fault!

That is bad.
> I have investigated this and posted a preliminary patch in another mail:
> http://subversion.tigris.org/servlets/ReadMsg?listName=dev&msgNo=141887

Steve and Julian, could one of you take a look at this?

> I would like this patch to be committed on the tree-conflicts branch, so
> that continuing work on fixing tree-conflicts situations can be comprehensive.

I'll leave that to Steve and Julian as well, as I'm bound up
with other things at the moment.


To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-17 15:22:08 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.