[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] assertion failure: 'svn subcommand uri://'

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: Sat, 16 Aug 2008 20:35:32 +0200

Hyrum K. Wright wrote:
> Toby Peterson wrote:
>> Looks like this might already be fixed in trunk, I was dealing with a
>> bug report against 1.5.1. So, feel free to ignore if that is the case.
> Do you know when it was fixed? If so, has it been backported to
> 1.5.x? This seems like something we would want in 1.5.2.
I think it's r31725, based on the log message.

>>> Easily reproducible:
>>> svn log http://
>>> svn ls svn+ssh://
>>> svn pl blah://
>>> It's a fairly obscure edge case, but zsh's completion appears to try
>>> to run 'svn list svn+ssh://' in some cases.
>>> [[[
>>> Fix an assertion failure when running 'svn subcommand uri://'.
>>> * subversion/libsvn_subr/path.c
>>> (svn_path_is_uri_safe): Invalidate path if it consists of a URI
>>> scheme only.
>>> ]]]
@Toby: your patch is good, but it would be complete if you also added a
unit test - see subversion/tests/libsvn_subr/path-test.c or a complete
regression test, see subversion/tests/cmdline/basic_tests.py..May be for
the next time you fix a bug. :)



To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-16 20:36:05 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.