[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

How wrong can we get a short doc-string?

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Thu, 14 Aug 2008 18:02:02 +0100

For our collective shame ...

In libsvn_client/merge.c:
> /* Get REVISION of the file at URL. SOURCE is a path that refers to that
> file's entry in the working copy, or NULL if we don't have one. Return in
> *FILENAME the name of a file containing the file contents, in *PROPS a hash
> containing the properties and in *REV the revision. All allocation occurs
> in POOL. */

There's no argument named 'REVISION' (it's 'REV').
There's no argument named 'URL', nor anything that looks like one.
There's no argument named 'SOURCE', but two possible alternatives.
There is an argument named 'RA_SESSION' that's not mentioned.
There is an argument named 'WC_TARGET' that's not mentioned.

Bloody hell.
Excuse my language.

> static svn_error_t *
> single_file_merge_get_file(const char **filename,
> svn_ra_session_t *ra_session,
> apr_hash_t **props,
> svn_revnum_t rev,
> const char *wc_target,
> apr_pool_t *pool)

I'll go and figure out what it's supposed to be, as I think I may want to use it.

- Julian

To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-14 19:02:25 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.