Re: [PATCH] copy file to existing directory.

On Tue, Aug 12, 2008 at 02:56:38PM +0800, Rui, Guo wrote:
> My solution is to prevent the second call to setup_copy() in
> svn_client_copy4() and failed to make it work for all cases. I think I should
> combine a call to svn_path_is_url() with the svn_io_check_path().
>
> Your solution sounds good. But I suspect that we won't be able to go this far
> -- the svn_wc_adm_open() will raise a error for the desitination before we can
> go into svn_wc_copy2().

Oh, OK. That might be the case, I haven't checked.

But in that case, we could catch the case inside of setup_copy(), right?
I think it's better to do it there than outside of setup_copy() anyway.

Because setup_copy() already does things like checking whether the
source is a URL, it seems more suitable to modify setup_copy()
instead of its caller.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-12 12:40:38 CEST