[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Fix issue #1672: WC gets out of sync if an update deleting a dir prop is interrupted

From: Vlad Georgescu <vgeorgescu_at_gmail.com>
Date: Tue, 12 Aug 2008 11:15:04 +0300


I haven't worked on Subversion for a while, so I'm posting this patch for review.

Link to issue: http://subversion.tigris.org/issues/show_bug.cgi?id=1672

Fix issue #1672: If an update that deletes a dir prop is interrupted,
the property will stay present even after restarting the update, causing the dir
to become out of sync with the repository.

* subversion/libsvn_wc/update_editor.c
  (dir_baton): Add new member 'was_incomplete'.
  (make_dir_baton): Initialize was_incomplete to FALSE.
  (open_root, open_directory): Set was_incomplete to the value of
  (close_directory): If the directory was incomplete before the update,
   all base props that weren't also among the incoming prop changes must
   be deleted.

* subversion/tests/cmdline/update_tests.py
  (test_list): Remove XFail from restarted_update_should_delete_dir_prop().


To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org

Received on 2008-08-12 10:15:44 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.