[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Fwd: Subversion AppleDouble patch updated to 1.5.0

From: Stefan Sperling <stsp_at_elego.de>
Date: Mon, 11 Aug 2008 16:46:20 +0200

On Mon, Aug 11, 2008 at 03:28:58PM +0100, Julian Foad wrote:
> > I wonder if the patch is the way to go.
> > I mean, where do we draw the line?
> > If we have svn:executable, why not have svn:appledouble?
> Good question. My personal feeling is that we SHOULD be willing to have
> some features like this that support OS filesystem features, and also
> that each addition of such a feature should improve the modularity of
> the implementation for such features. I expect the existing support for
> svn:executable and symlinks is rather tightly tied in to low-level code,
> and we should endeavour to uncouple it a bit and make sure that any new
> code like this AppleDouble feature is not too tightly mixed in with
> everything else, as far as we can.


But expecting patch submitters to do that (i.e. clean up
architectural deficiencies of Subversion for us in addition
to adding the functionality they need) is unreasonable.

> If we decide that the best
> (maintainable) way to do this is to have a wrapper layer around
> Subversion, then
> * we should help to create and support this layer;
> * we should move the svn:executable and symlink support into it.
> This wrapper layer might be a C-language layer above libsvn_wc, rather
> than outside the "svn" client, so it available to all clients.

I really like this idea. We might want to make this a long-term goal.
But creating a totally new layer will not help anyone in the short term
unless somebody starts working on this, like, right now.

> As for this particular AppleDouble feature: I don't imagine the feature
> complexity (likelihood of complex bugs, interactions with other
> features, ...) being much greater than for, say, symlink support. So
> let's have a look at it.

I've looked at the patch and I agree that it's not much
more complicated than symlinks. The guts of the code is
about getting the meta data from the OS. It's just copying
stuff around, basically. Granted, it needs some stylistic
cleanup, but that is no problem.

I'm still a bit concerned about the license status of that header
file, though. That should be cleared up.

But I cannot review it properly though because of lack of time.
And I don't have a Mac.


To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-11 16:46:48 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.