[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: fsfs-reshard.py not ready for prime time?

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Mon, 11 Aug 2008 02:03:41 -0400

"David Glasser" <glasser_at_davidglasser.net> writes:
> On Sun, Aug 10, 2008 at 8:35 AM, Mark Phippard <markphip_at_gmail.com> wrote:
>> On Sun, Aug 10, 2008 at 11:27 AM, Karl Fogel <kfogel_at_red-bean.com> wrote:
>>> In http://svn.collab.net/repos/svn/trunk/tools/server-side/fsfs-reshard.py,
>>> this block appears at the end:
>>>
>>> if __name__ == '__main__':
>>> raise Exception, \
>>> """This script is unfinished and not ready to be used on live data.
>>> Trust us."""
>>> main()
>>>
>>> The exception-raise was added in r24552 by Malcolm:
>>>
>>> * tools/server-side/fsfs-reshard.py
>>> Prevent use, for now, and add a license block.
>>>
>>> Suggested by: cmpilato
>>>
>>> Since then there have been a few commits to fsfs-reshard.py, but the
>>> exception is still in place. Do we know exactly what it is that is
>>> making fsfs-reshard.py be not ready for production use? The reason I
>>> ask is that people are starting to write their own reshard scripts (see
>>> the mail below from users@)...
>>
>> From what I remember, I thought the only issue was that when you
>> wanted to use the script to go back to the 1.4 format it took a really
>> long time.
>
> ISTR it was just never particularly tested or reviewed by more than
> one or two people.

Hrm. The warning message is a lot stronger than that. Should we change
it to

  "This script is not widely tested. Please make a backup of your
   repository before running it. Run with '--really' to avoid this
   warning and make the script actually run."

Or something like that?

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-11 08:04:00 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.