[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] copy file to existing directory.

From: Rui, Guo <timmyguo_at_mail.ustc.edu.cn>
Date: Sun, 10 Aug 2008 23:49:48 +0800

On Sun, Aug 10, 2008 at 10:48:15AM -0400, Karl Fogel wrote:
> >
> > This is not only simplify the condition. Please see the comment in the code.
> > This branch will try to copy the source as an sub-entry of the destination if
> > the destination exists. However, its only meaningful when the destination
> > exists in the FS. An hidden entry will show an obvious exception to this. In
> > such a situation, only the entry exists.
> >
> > PS: The same logic also apply to the move command. You may have to add a
> > similar modification as above.
> Oops. All this depends on the misunderstanding of what "FS" means. I'm
> sorry; I wish I had realized earlier!
> Traditionally, in Subversion, "FS" refers to the repository filesystem.
> You'll see that convention elsewhere in the code, too.
Thanks. And Stefan also clarified this for me. So I just provide a new patch.

Handles the situation of existing destination directory better for copy/move.

* subversion/libsvn_wc/copy.c
  (copy_file_administratively): Check the existence of target directory.

* subversion/libsvn_client/copy.c
  (svn_client_copy4, svn_client_move5): Only copy as child if the destination
   exists in the local filesystem.


Also I find that there is one more question in the end of the original post,
about retained 'deleted' flag after revert.

Best regards,

To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-10 17:50:11 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.