[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Issue #3255: client capabilities in start-commit

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Sat, 09 Aug 2008 19:21:11 -0400

Eric Gillespie <epg_at_pretzelnet.org> writes:
> Karl Fogel <kfogel_at_red-bean.com> writes:
>> The second option is viable, I think: have the client transmit its
>> capabilities with *every* request. It's too late for 1.5.0 and 1.5.1,
>> but we could probably justify this for 1.5.2, and certainly for 1.6.0.

Done in r32417.

The change adds no extra network turnarounds, but it does add some more
headers to every request. I don't see any way around that: since our
server is amnesiac when KeepAlive is off, the client must continually
repeat the capabilities into the server's ear. It wouldn't be enough to
just add the headers for those requests that could result in an
invocation of start-commit, because while that might fix this bug, it
would leave other bugs waiting to happen -- in theory, the server might
need to know the client's capabilities at any time, after all.

> +1 to getting this in 1.5.2; it's a bug-fix, and an important
> feature is worthless to the poor saps stuck on davsvn.

Nominated for 1.5.2 (and it does apply cleanly; I tested).


To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-10 01:21:47 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.