-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Fixed all in r32394.
Thanks for the review.
With regards
Kamesh Jayachandran
Hyrum K. Wright wrote:
> blair_at_tigris.org wrote:
>> Author: blair
>> Date: Wed Aug 6 07:04:01 2008
>> New Revision: 32378
>>
>> Log:
>> * subversion/include/svn_dso.h
>> (svn_dso_initialize2):
>> List before svn_dso_initialize() to be consistent with the listing
>> of all our other deprecated APIs.
>>
>> Modified:
>> trunk/subversion/include/svn_dso.h
>>
>> Modified: trunk/subversion/include/svn_dso.h
>> URL:
>> http://svn.collab.net/viewvc/svn/trunk/subversion/include/svn_dso.h?pathrev=32378&r1=32377&r2=32378
>>
>> ==============================================================================
>>
>> --- trunk/subversion/include/svn_dso.h Wed Aug 6 07:02:44 2008
>> (r32377)
>> +++ trunk/subversion/include/svn_dso.h Wed Aug 6 07:04:01 2008
>> (r32378)
>> @@ -45,13 +45,12 @@ extern "C" {
>> * into the previously mentioned problems with DSO unloading and
>> * pool cleanup callbacks.
>> *
>> - * Calls svn_dso_initialize2(void) upon error aborts.
>> - *
>> - * @deprecated Provided for backwards compatibility with the 1.4 API.
>> + * Returns svn_error_t object with corresponding apr_err returned by
>> + * underlying calls. In case of no error returns @c SVN_NO_ERROR.
>> *
>> - * @since New in 1.4.0.
>> + * @since New in 1.6.0.
>
> Minor nit: since APIs are only introduced in .0 releases, we usually
> just leave off that part from the @since and @deprecated tags.
>
>> */
>> -void svn_dso_initialize(void);
>> +svn_error_t *svn_dso_initialize2(void);
>>
>> /**
>> * Initialize the DSO loading routines.
>> @@ -66,12 +65,13 @@ void svn_dso_initialize(void);
>> * into the previously mentioned problems with DSO unloading and
>> * pool cleanup callbacks.
>> *
>> - * Returns svn_error_t object with corresponding apr_err returned by
>> - * underlying calls. In case of no error returns @c SVN_NO_ERROR.
>> + * Calls svn_dso_initialize2(void) upon error aborts.
>> *
>> - * @since New in 1.6.0.
>> + * @deprecated Provided for backwards compatibility with the 1.4 API.
>
> If the new API was introduced in 1.6, wouldn't the old one be provided
> for compat with the 1.5 API?
>
>> + *
>> + * @since New in 1.4.0.
>
> See above note about .0 in @since tags.
>
>> */
>> -svn_error_t *svn_dso_initialize2(void);
>> +void svn_dso_initialize(void);
>>
>> #if APR_HAS_DSO
>> /**
>
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFImuaX3WHvyO0YTCwRArkfAJ9gL9AeYQJdVOinvYcdxikdMA8U+QCgsafr
Dv1TraBg1R4WwRqXUO+uT0k=
=uo1d
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-07 14:13:13 CEST