[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Do lock tokens need to be unique?

From: Chia-liang Kao <clkao_at_clkao.org>
Date: Tue, 5 Aug 2008 12:07:03 -0400

2008/8/5 Karl Fogel <kfogel_at_red-bean.com>:
>> I was almost done with the patch, but discovered mod_dav_svn handles this a
>> bit differenetly. I had a chat with justin, it seems in protocol layer, when
>> committing lock tokens are provided by client in the If header, so the path
>> info here is lost.
>> so in this case we might need to revision the ra_get_commit_editor API to take
>> only a list of tokens...
> I don't think revving that API is a huge problem.
> I didn't understand the "to take only a list of tokens" part, though.
> It already takes a hash of lock tokens; anyway, isn't it the paths
> you're missing, not the tokens? But the hash is keyed by path...

the ra api does take hash of lock tokens, but i was looking with
justin at the individual put request (for dav server) where only lock
tokens were given. but turned out the merge request at the end does
have all the info I needed, so i sent the patch: [PATCH] Make
pre-commit hook have access to lock tokens



To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-05 18:07:19 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.