On Mon, Aug 4, 2008 at 9:07 AM, Julian Foad <julianfoad_at_btopenworld.com> wrote:
> On Mon, 2008-08-04 at 17:51 +0200, Achim Spangler wrote:
>> Dear Blair,
>> do you know any place in SVN source code, where:
>> + different errors are combined to a list
>> -> is there already infrastructure or reference style
>> for this case?
>
> Every error can have other errors attached to it in a chain. One example
> of doing this is in unsupported_diff_error() in
> subversion/libsvn_client/diff.c.
>
>> + low level error is interpreted at caller side just as
>> warning
>> -> I found no call of the new functions svn_handle_warning2()
>> and svn_handle_warning()
>
> [[[
> $ grep svn_handle_warning subversion/*/*.c
> subversion/libsvn_subr/error.c:svn_handle_warning(FILE *stream,
> svn_error_t *err)
> subversion/libsvn_subr/error.c: svn_handle_warning2(stream, err, "svn:
> ");
> subversion/libsvn_subr/error.c:svn_handle_warning2(FILE *stream,
> svn_error_t *err, const char *prefix)
> subversion/svn/main.c: svn_handle_warning(stderr, err);
> subversion/svn/notify.c: svn_handle_warning(stderr, n->err);
> subversion/svn/notify.c: svn_handle_warning(stderr, n->err);
> subversion/svn/props.c: svn_handle_warning(stderr, err);
> subversion/svn/resolve-cmd.c: svn_handle_warning(stderr, err);
> subversion/svn/resolved-cmd.c: svn_handle_warning(stderr, err);
> subversion/svn/util.c: svn_handle_warning(stderr, err);
> subversion/tests/svn_test_fs.c: svn_handle_warning(stderr, err);
> ]]]
The key thing you need to notice here is that you can't call
svn_handle_warning from our libraries, only from the svn command-line
client.
--dave
>
> - Julian
>
>
>> The problem is, that "handle_externals_desc_change()" has no access to the
>> output stream, where a warning message could get displayed. Thus a local
>> solution in the scope of "handle_externals_desc_change()" seems to be not
>> possible. Now I'm looking for an appropriate way to get the error information
>> as warning information at the initial caller.
>>
>> As soon, as somebody can help me with these questions, I can try to find a
>> real solution.
>>
>> Thanks,
>> Achim
>> Am Montag, 4. August 2008 schrieben Sie:
>> > On Aug 4, 2008, at 4:12 AM, Achim Spangler wrote:
>> > > Hi,
>> > > as this bug report wasn't processed for 1.5.1 release, I tried to
>> > > get some
>> > > clues on this problem on my own.
>> >
>> > Hi Achim,
>> >
>> > If you can supply a patch and test case to implement the desired
>> > behavior, I can review it and commit it if it passes review.
>> >
>> > Regards,
>> > Blair
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
>> For additional commands, e-mail: dev-help_at_subversion.tigris.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
> For additional commands, e-mail: dev-help_at_subversion.tigris.org
>
>
--
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-04 19:55:49 CEST