Stefan Küng wrote on Sat, 2 Aug 2008 at 12:27 +0200:
> Stefan Sperling wrote:
> > The API docs for svn_ra_progress_notify_func_t do not say
> > whether the callback should pass the sum of bytes transferred
> > so far, or just the amount of bytes transferred since the last
> > time the callback was called:
> >
> > /**
> > * Callback function type for progress notification.
> > *
> > * @a progress is the number of bytes already transferred, @a total is
As I read it, it promises the (current) ra_svn behaviour.
2˘,
Daniel
> > * the total number of bytes to transfer or -1 if it's not known, @a
> > * baton is the callback baton.
> > *
> > * @since New in 1.3.
> > */
> > typedef void (*svn_ra_progress_notify_func_t)(apr_off_t progress,
> > apr_off_t total,
> > void *baton,
> > apr_pool_t *pool);
> >
> > We should probably make the API docs explicit as well as making
> > all RA layers do consistent reporting.
>
> New patch attached, this time with correction to the doc string.
>
> Stefan
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-02 12:35:39 CEST