Re: [PATCH] svn_dso_initialize can *silently* fail to create lock

On Sat, Aug 02, 2008 at 12:27:19AM +0530, Kamesh Jayachandran wrote:
> >I would suggest using
>
> > SVN_ERR_ASSERT(status == APR_SUCCESS);
>
> It will give a compiler warning as the caller here is a void function and
> SVN_ERR_ASSERT would evaluate to 'return svn_error_t *'.

Oh, I didn't realise that, sorry.

I would suggest we provide a new svn_dso_initialize2 which returns
(svn_error_t *) and uses SVN_ERR_ASSERT, for 1.6 clients.
For pre-1.6 clients, we can abort().

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-01 21:57:47 CEST