Re: svn commit: r32343 - trunk/subversion/libsvn_client

Karl,

This commit and the previous r32342 fix this bug which you put a patch on:

http://subversion.tigris.org/issues/show_bug.cgi?id=3246

Do we want to use your patch?

We could warn or fail if there is a duplicate external target. With the trunk
code, we don't need to do either, but we could for a UI point of view.

Even determining duplicate entries could be hard, as a user could use different
types of relative URLs that still refer to the same absolute source URL. But
then, depending upon the type of relative URL and the checkout URL, they could
resolve to different absolute source URLs depending upon the checkout URL, so
the comparison results would vary.

So it's probably best just to check the external target and either warn or fail
if a duplicate it found.

Ahh, but then the user could have this

dir1/ <- has external checking out at dir2/external-foo
dir1/dir2 <- has external checking out at external-foo

and our code wouldn't catch this case.

Blair

blair_at_tigris.org wrote:
> Author: blair
> Date: Thu Jul 31 08:34:51 2008
> New Revision: 32343
>
> Log:
> Fix #3246. The absolute or relative URLs in the
> svn_wc_external_item2_t that are replaced by an absolute URL should be
> allocated from a pool that is not cleared upon the handling of each
> external item.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-31 17:49:01 CEST