Re: svn commit: r32318 - in trunk/subversion: svndumpfilter tests/cmdline tests/cmdline/svndumpfilter_tests_data

Daniel Shahaf wrote:
> hwright_at_tigris.org wrote on Mon, 28 Jul 2008 at 17:40 -0700:
>> Author: hwright
>> Date: Mon Jul 28 17:40:18 2008
>> New Revision: 32318
>>
>> Log:
>> Add '--targets' option to svndumpfilter, with the usual semantics. This
>> addresses issue #2697.
>>
>> --- trunk/subversion/tests/cmdline/svndumpfilter_tests.py Mon Jul 28 03:54:45 2008 (r32317)
>> +++ trunk/subversion/tests/cmdline/svndumpfilter_tests.py Mon Jul 28 17:40:18 2008 (r32318)
>> @@ -140,9 +212,11 @@ def svndumpfilter_loses_mergeinfo(sbox):
>> test_list = [ None,
>> reflect_dropped_renumbered_revs,
>> svndumpfilter_loses_mergeinfo,
>> + dumpfilter_with_targets,
>> ]
>>
>> if __name__ == '__main__':
>> + warnings.filterwarnings('ignore', 'tempnam', RuntimeWarning)
>> svntest.main.run_tests(test_list)
>> # NOTREACHED
>>
>>
>
> Do we still need this filterwarnings() call? It passes fine for me:
>
> % svn di
> Index: subversion/tests/cmdline/svndumpfilter_tests.py
> ===================================================================
> --- subversion/tests/cmdline/svndumpfilter_tests.py (revision 32321)
> +++ subversion/tests/cmdline/svndumpfilter_tests.py (working copy)
> @@ -216,7 +216,6 @@
> ]
>
> if __name__ == '__main__':
> - warnings.filterwarnings('ignore', 'tempnam', RuntimeWarning)
> svntest.main.run_tests(test_list)
> # NOTREACHED
>
> % make check TESTS=subversion/tests/cmdline/svndumpfilter_tests.py
> Running all tests in svndumpfilter_tests.py [1/1]...success
> % python -V
> Python 2.5.2

Without this line, I get errors with Python 2.5.1 on OS X.

-Hyrum