[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] hooks-scripts: fix svn2feed.py on Windows

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Fri, 25 Jul 2008 21:32:28 +0300 (Jerusalem Daylight Time)

Ping; this last iteration of the patch has received little response.

URL: http://thread.gmane.org/gmane.comp.version-control.subversion.devel/101880/focus=101933

(more below)

Niels de Vos wrote on Mon, 30 Jun 2008 at 12:14 +0200:
> Here's a patch for review with popen.popen* replaced by the
> subprocess-module. It should work on both UNIX and Windows. Only tested
> on UNIX for now.
>
> Note that this patch also changes the output of the feed to match the
> format of viewvc more.
>
> I could update the patch to only reflect the popen-subprocess change if
> needed.
>

Please do so; one patch should contain one logical change, and patches
that contain multiple unrelated changes are much less likely to be
applied.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-25 20:34:23 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.