[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r32259 - branches/1.5.x

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Wed, 23 Jul 2008 06:58:26 -0700

kameshj_at_tigris.org wrote:
> Author: kameshj
> Date: Wed Jul 23 05:17:58 2008
> New Revision: 32259
>
> Log:
> STATUS: Nominate r32236.
>
> Modified:
> branches/1.5.x/STATUS
>
> Modified: branches/1.5.x/STATUS
> URL: http://svn.collab.net/viewvc/svn/branches/1.5.x/STATUS?pathrev=32259&r1=32258&r2=32259
> ==============================================================================
> --- branches/1.5.x/STATUS Wed Jul 23 05:08:43 2008 (r32258)
> +++ branches/1.5.x/STATUS Wed Jul 23 05:17:58 2008 (r32259)
> @@ -42,6 +42,12 @@ Candidate changes for 1.5.1:
> Votes:
> +1: pburba, cmpilato
>
> + * r32236
> + This should have been part of #3220 & #3235 group, just got missed.
> + Lack of this revision causes 'log_tests.py' and 'blame_tests-10' to fail.

That's a great justification for this revision, but could you also include a
summary of r32236? Even just the log message would be fine. We just need
something which helps reviewers identify this revision, not just the reasons
that it should be merged.

(I'm not trying to pick on you, we've just gotten a little sloppy with our
STATUS entries as of late, and I'm trying to point it out when I see it.)

-Hyrum

> + Votes:
> + +1: kameshj
> +
>
> Approved changes:
> =================

Received on 2008-07-23 15:58:50 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.