Do lock tokens need to be unique?

Is it strictly necessary that we guarantee the uniqueness of lock tokens?

For more context, see this thread:

   "[PATCH] allow pre-lock hook to specify token for locking"
   http://subversion.tigris.org/servlets/BrowseList?list=dev&by=thread&from=667592

It's only six messages long (right now, anyway). We're trying to figure
out if losing the guarantee that lock tokens are unique would cause any
badness in the real world. Note cmpilato's post in the thread about how
it's a WebDAV spec issue. He points to this:

   http://www.webdav.org/specs/rfc2518.html#rfc.section.6.3

As with other supposedly unique things, it gets more complicated when
svnsync and friend enter the picture. My feeling is we should permit
the pre-lock hook to generate a token, and just put a warning where we
document it, pointing out that generating a non-unique token technically
violates that spec and that anyone who writes such a hook should be
aware of this.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-21 23:49:00 CEST