[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r32208 - trunk/subversion/libsvn_repos

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Mon, 21 Jul 2008 16:56:43 -0400

"Chia-liang Kao" <clkao_at_clkao.org> writes:
>>> - PATH is the path being unlocked, USERNAME is the person doing it. */
>>> + PATH is the path being unlocked, USERNAME is the person doing it,
>>> + TOKEN is the lock token to be unlocked, and BREAK-LOCK is a flag if
>>> + the user is breaking the lock. */
>>> svn_error_t *
>>> svn_repos__hooks_pre_unlock(svn_repos_t *repos,
>>
>> Likewise for TOKEN.
>
> Actually token should never be null, so the code for checking null is
> probably redundant.

Oh, I'm not talking about the code, I'm talking about the doc string.
If TOKEN should never be null, then that needs to be documented.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-21 22:57:05 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.