[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r31987 - in branches/issue-2843-dev/subversion: libsvn_wc tests/cmdline

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Mon, 21 Jul 2008 16:51:25 -0400

"Rui, Guo" <timmyguo_at_mail.ustc.edu.cn> writes:
>> What if a child has both entry->deleted==TRUE and
>> entry->depth==svn_depth_exclude? Or is that supposed to be impossible?
>
> We should prevent this from happening. entry->deleted == TRUE just means that
> the item is gone from the repos. However, the exclude assumes the item exists
> in the repos.

Just curious: if we have a tree T with excluded item E, what happens if
we do an update and it turns out E is now removed in the repository? Do
we locally receive the removal, and therefore remove any record of E in
the working copy?

>> > + # copy A/B to A/L
>> > + expected_output = ['A '+L_path+'\n']
>> > + svntest.actions.run_and_verify_svn(None, expected_output, [],
>> > + 'cp', B_path, L_path)
>> > +
>> > + # revert A/L
>> > + expected_output = ["Reverted '"+L_path+"'\n"]
>> > + svntest.actions.run_and_verify_svn(None, expected_output, [],
>> > + 'revert', '--depth=infinity', L_path)
>> > +
>> > + svntest.actions.run_and_verify_svn(None, None, [],
>> > + 'rm', '--force', L_path)
>> > +
>> > # Exclude path B totally, in which contains an excluded subtree.
>> > expected_output = svntest.wc.State(wc_dir, {
>> > 'A/B' : Item(status='D '),
>>
>> ...it might be good to add a comment about what is being tested for in
>> this new code.
>
> Just test the simple case of copy & revert. Maybe I should make it
> more clear?

Yes, I think that would help.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-21 22:51:46 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.