Re: Subversion sometimes needlessly asks for confirmation to store already stored plaintext passwords

Hi Stefan,

Stefan Sperling wrote:
> Senthil,
>
> I've reviewed this change, +1.
>
> Here's a rewritten log message that explains better what problem
> we are fixing:

Though this fixes the problem, it did not pass the tests. The recently added
"basic auth tests" in basic_tests.py breaks due to this change.

Basically in my previous email this is "use case 2". I am working on another
patch for the same, which have more changes (modifies the flow of this
function) inside "svn_auth__simple_first_creds_helper" which I will post to the
dev list once completed.

But if anyone feel that the change which I am working on is not needed, please
let me know, in which case we need to invalidate "basic auth tests" in
basic_tests.py, But I would love to work on this, though it will change the
logic of private function "svn_auth__simple_first_creds_helper" entirely.

Thank You.

-- 
Senthil Kumaran S
http://www.stylesen.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org