[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [RFC] Remove AS400 code from trunk (Was: [PATCH] allow pre-lock hook to specify token for locking)

From: Arfrever Frehtes Taifersar Arahesis <arfrever.fta_at_gmail.com>
Date: Thu, 17 Jul 2008 21:25:50 +0200

2008-07-17 21:10:46 Paul Burba napisaƂ(a):
> 2008/7/16 Chia-liang Kao <clkao_at_clkao.org>:
> > (This is only a preliminary patch)
> >
> > The patch enabling the pre-lock hook to decide the lock_token to be
> > used in the lock operation, which is usually autogenerated. The
> > changes are mostly in run_hook_cmd, making it to optionally take
> > stdout and return it as a string.
> > The function is basically reimplemented for AS400 though, so I'd
> > appreciate helps for making the relevant code changes in the other
> > part of the #ifdef... (I was also wondering why such abstraction
> > didn't happen in svn_io_start_cmd level though)
>
> As clkao and I just discussed on IRC, the AS400 port has not been
> actively maintained since Jan 2007 and AFAIK nobody has any plans to
> do so. So I'm +1 for removing the AS400 implementation of
> run_hook_cmd.
>
> Further, I'd like to make a sweep of trunk and remove all AS400
> specific code. If anyone ever takes up the port again it's still all
> there, the beauty of version control and all :-)
>
> Any objections?

+1

-- 
Arfrever Frehtes Taifersar Arahesis

Received on 2008-07-17 21:28:10 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.