Re: [RFC] Remove AS400 code from trunk (Was: [PATCH] allow pre-lock hook to specify token for locking)

On Thu, Jul 17, 2008 at 3:10 PM, Paul Burba <ptburba_at_gmail.com> wrote:
> 2008/7/16 Chia-liang Kao <clkao_at_clkao.org>:
>> (This is only a preliminary patch)
>>
>> The patch enabling the pre-lock hook to decide the lock_token to be
>> used in the lock operation, which is usually autogenerated. The
>> changes are mostly in run_hook_cmd, making it to optionally take
>> stdout and return it as a string.
>> The function is basically reimplemented for AS400 though, so I'd
>> appreciate helps for making the relevant code changes in the other
>> part of the #ifdef... (I was also wondering why such abstraction
>> didn't happen in svn_io_start_cmd level though)
>
> As clkao and I just discussed on IRC, the AS400 port has not been
> actively maintained since Jan 2007 and AFAIK nobody has any plans to
> do so. So I'm +1 for removing the AS400 implementation of
> run_hook_cmd.
>
> Further, I'd like to make a sweep of trunk and remove all AS400
> specific code. If anyone ever takes up the port again it's still all
> there, the beauty of version control and all :-)
>
> Any objections?

+1

No one is maintaining the code and as you said, it can always be resurrected.

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org