Committed in r32147, thanks.
Just for next time: it's best to always post log message and patch
together, so no one has to think about which log message goes with which
patch. Even when there is only one patch and multiple log messages, as
in this case, it's still easy to get confused. The goal to aim for is
one single mail message that overrides all previous mails, and says so
clearly. That way, the most thinking anyone has to do is to compare
dates on messages.
By the way, I think Peter Samuelson was right, in this case: the IRC
transcript wasn't adding much information after all, so I used a
different log message.
-Karl
Senthil Kumaran S <senthil_at_collab.net> writes:
> Senthil Kumaran S wrote:
>> Hi Karl,
>>
>> Karl Fogel wrote:
>>> It's okay to include that IRC transcript in your log message, to give
>>> the reader an understanding of what motivates the change.
>>
>> Updated the log message, but I am not sure whether this is the right
>> way to include IRC transcript. I used kf-irc-prettify
>> (http://svn.red-bean.com/repos/kfogel/trunk/.emacs) and some manual
>> edition in order to format the IRC log message.
>
> The log message which I gave in my previous email contains some
> characters in different encoding inside the IRC transcript, corrected
> that and here is the new log message (sorry for the noise).
>
> [[[
> Do not print log separator in contribulyze.
>
> * tools/dev/contribulyze.py
> (graze): If there is no final newline at the end of a log message,
> move to the next log message.
>
> IRC transcript:
> danielsh: stylesen: morning :) what was the purpose of the propedits
> you did this afternoon?
>
> Arfrever: danielsh: I guess that he added missing lines at the end
> of log messages.
>
> stylesen: danielsh: Good night :) they did not have a final n
> line, which appeared a bit ugly when I did 'svn log | less' on the
> 1.5.x branch, but later after 2 or 3 revisions I realized, there
> are lot of log messages like that, so stopped after 2 or 3 revisions!
>
> danielsh: stylesen: ah, thanks.
>
> ***danielsh has autocmd FileType svn set noendofline...
> (English: all my log messages don't have terminating newline)
>
> stylesen: danielsh: A basic problem when we dont have final n
> line is in contriubulize where after the log message the
> '--------------' line also appears in the listing
>
> danielsh: stylesen: it's a bug in contribulyze.py, then.
>
> stylesen: danielsh: okie will fix it :)
>
> danielsh: stylesen: cool :)
>
> Patch by: stylesen
> ]]]
>
> Thank You.
> --
> Senthil Kumaran S
> http://www.stylesen.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-16 22:40:42 CEST