[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: unlock hook completeness?

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Tue, 15 Jul 2008 16:51:17 -0400

Chia-liang Kao <clkao_at_clkao.org> writes:
> Here's my proposed change (as in the hook templates). I was a bit
> unsure about having comment passed in as argument or stdin though. If
> this looks reasonable then I will put a patch together.

Looks good to me. For STEAL-LOCK and BREAK-UNLOCK, you'll need to
specify what exactly the argument looks like -- that is, how you're
going to represent a boolean value in someone's char **argv :-).

The COMMENT can potentially be a multiline value. That's okay, the hook
is fine receiving a multiline value in one of its args, right?

-Karl

> --- subversion/libsvn_repos/repos.c (revision 32132)
> +++ subversion/libsvn_repos/repos.c (local)
> @@ -537,6 +537,8 @@ PREWRITTEN_HOOKS_TEXT
> "# [1] REPOS-PATH (the path to this repository)" NL
> "# [2] PATH (the path in the repository about to be locked)" NL
> "# [3] USER (the user creating the lock)" NL
> +"# [4] COMMENT (the comment of the lock)" NL
> +"# [5] STEAL-LOCK (if the user is trying to steal the lock)" NL
> "#" NL
>
> "# The default working directory for the invocation is undefined, so" NL
> "# the program should set one explicitly if it cares." NL
> @@ -618,6 +620,8 @@ PREWRITTEN_HOOKS_TEXT
> "# [1] REPOS-PATH (the path to this repository)" NL
> "# [2] PATH (the path in the repository about to be unlocked)" NL
> "# [3] USER (the user destroying the lock)" NL
> +"# [4] TOKEN (the lock token to be destoryed)" NL
> +"# [5] BREAK-UNLOCK (if the user is breaking the lock)" NL
> "#" NL
> "# The default working directory for the invocation is undefined, so" NL
> "# the program should set one explicitly if it cares." NL
>
> Cheers,
> CLK
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
> For additional commands, e-mail: dev-help_at_subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-15 22:51:58 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.