Re: Should start-commit hook include log message parameter?

kmradke_at_rockwellcollins.com writes:
> svn:author is already passed to the start-commit script, so there is
> a little precedence here. If the svn:log message is passed to
> the start-commit script it might get a little interesting making sure
> the free-form text is passed and parsed correctly.

You could use stdin, the way pre-revprop-change and post-revprop-change
do.

> Not sure I'm real happy with creating an unfinished transaction either.
> (However, this would allow us to essentially send all the props and
> easily add new ones in the future without adding parameters to the
> script.)

Well, if start-commit returns non-zero, then that txn should be removed,
of course. But I think stdin is better; part of the point of
start-commit is that it runs at the cheapest possible time. If we
create a txn, we're going down a slippery slope. In practical terms, we
know that author and log message are what people want, so let's offer
them, via an arg and stdin, respectively.

> pre-pre-commit? post-start-commit? :^)

I was thinking about that, but it really makes most sense to put this in
start-commit, rather than create a new hook that runs at a time that is
special only to Subversion developers.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-15 21:46:57 CEST