Re: svn commit: r32083 - trunk/subversion/libsvn_subr

Daniel Shahaf <d.s_at_daniel.shahaf.name> writes:
>> + /* We're interactive, and the client provided a
>> + * prompt callback. So we can ask the user.
>> + *
>> + * Check for a cached answer before prompting. */
>> + svn_boolean_t cached_answer =
>> + (svn_boolean_t) apr_hash_get(b->plaintext_answers,
>> + realmstring,
>> + APR_HASH_KEY_STRING);
>
> I might be overlooking something (again), but how does this code
> distinguish between "no answer is cached" (apr_hash_get() returns NULL)
> and "an answer is cached, and it is 'FALSE'" (apr_hash_get() returns
> FALSE)?

Oh, good point. I think I completely botched this.

> Also, why does this use APR_HASH_KEY_STRING? A pointer -- or a boolean
> -- aren't a string.

That's a good question, and it applies in the pointer case too.

I'll dig in and fix this. Thanks for catching, Daniel.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-15 21:13:55 CEST