Re: [PATCH] Do not print log separator in contribulyze.

Senthil Kumaran S <senthil_at_collab.net> writes:
> [[[
> Do not print log separator in contribulyze.
>
> * tools/dev/contribulyze.py
> (graze): If there is no "\n" at the end of a log message, do not print
> the log separator.
>
> Patch by: stylesen
> ]]]

It's okay to include that IRC transcript in your log message, to give
the reader an understanding of what motivates the change.

I'm confused, though: your log messages says "If there is no '\n' ... do
not print the log separator". But then your code change does something
else: it *replaces* the encountered log_separator with a newline. How
does it avoid combining two log messages into one? The patch never sets
'just_saw_separator' or does any of the other "we just encountered a
boundary" stuff... However, when I tested, I didn't see any log entries
get combined, so it might be that your patch is correct and I just don't
understand why :-).

But in any case, when I tried to reproduce the bug without your patch, I
couldn't. Could you give a formal reproduction recipe?

The command line I used was:

   $ cd tools/dev
   $ ./contribulyze.py -U 'http://svn.collab.net/viewcvs/svn?rev=%s&view=rev' -C ../../COMMITTERS < log-data.in

And log-data.in contains this:

------------------------------------------------------------------------
r32124 | pburba | 2008-07-15 10:04:04 -0400 (Tue, 15 Jul 2008) | 2 lines

This is a fake log message for r32124, to test out contribulyze.py.

------------------------------------------------------------------------
r32123 | sunny256 | 2008-07-15 06:13:49 -0400 (Tue, 15 Jul 2008) | 4 lines

This is a fake log message for r32123, to test out contribulyze.py.

Patch by: J. Random Contributor <jrandom_at_example.com>
(Tweaked by me. Look, this log msg doesn't have its own final newline!)
------------------------------------------------------------------------
r32122 | pburba | 2008-07-14 21:25:56 -0400 (Mon, 14 Jul 2008) | 5 lines

This is a fake log message for r32122, to test out contribulyze.py.

Patch by: Some Other Contributor <anotherone_at_example.com>
(Tweaked by me. This log msg does have its own final newline.)

------------------------------------------------------------------------
r32121 | pburba | 2008-07-14 20:47:11 -0400 (Mon, 14 Jul 2008) | 2 lines

This is a fake log message for r32121, to test out contribulyze.py.

------------------------------------------------------------------------
r32120 | pburba | 2008-07-14 20:39:58 -0400 (Mon, 14 Jul 2008) | 2 lines

This is a fake log message for r32120, to test out contribulyze.py.

------------------------------------------------------------------------
r32119 | pburba | 2008-07-14 19:37:15 -0400 (Mon, 14 Jul 2008) | 2 lines

This is a fake log message for r32119, to test out contribulyze.py.

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-15 18:36:16 CEST