[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Simplify reporting of API violations of the conflict resolver callback.

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Tue, 15 Jul 2008 09:08:27 +0100

On Mon, 2008-07-14 at 19:05 -0400, Karl Fogel wrote:
> Julian Foad <julianfoad_at_btopenworld.com> writes:
> > Should I do this?
> >
> > My reasons: I think it makes the normal code path easier to read. I
> > don't think we have custom error messages for other API violation error
> > returns. It gets rid of some messages that are meaningful only to
> > programmers but of limited use to programmers, and relieves the
> > translators of translating them. I can't think of strong
> > counter-arguments but I'm wary that there may be some.
>
> With conflict callbacks, it may be particularly easy to write a buggy
> callback, and the situation-specific error messages we give right now
> can help people figure out what they did wrong.
>
> I have no evidence that the error message are or aren't helpful to
> people, but my instinct is to keep them. Wish I could justify that with
> something stronger than "Let's not lose information" :-).

Oh well... I suspected some people would feel like that. To me it gets
in the way, just a little bit, of understanding the code, which is
important, but I guess there are other ways to tackle that.

- Juloi

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-15 14:14:02 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.