Re: SVN 1.5.1 next week

"Mark Phippard" <markphip_at_gmail.com> writes:
> If I can merge these cleanly and all tests pass, are people OK with me
> adding a +1 on those items? I cannot do much more review than that.

I think we've long held that "+1" means one has actually reviewed the
change and found it okay. A change shouldn't even be listed if it
doesn't pass the tests (and anyway, we'd catch that in regular testing).

Not that I mean to discourage testing: if you want to merge+test and
then add something to the "Notes:" section describing your results,
that's always useful! But I don't think we should make +1 mean less
than we intended it to mean. (I agree it sucks that these big
merge-tracking changes are so hard to review, though :-( ).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-15 01:10:52 CEST