On Fri, 2008-07-11 at 09:06 +0530, Bhuvaneswaran A wrote:
> On Thu, 2008-07-10 at 18:46 +0100, Julian Foad wrote:
> > On Thu, 2008-07-10 at 17:08 +0000, bhuvan_at_tigris.org wrote:
> > > http://subversion.tigris.org/issues/show_bug.cgi?id=1952
> >
> > > ------- Additional comments from bhuvan_at_tigris.org Thu Jul 10 10:08:06 -0700 2008 -------
> > > Please find attached the patch for review. Pre-commit log message:
> > >
> > > Fix for issue 1952. Make the read-only variables visible by changing it
> > > to const pointer.
> > >
> > > * subversion/include/svn_repos.h
> > > (svn_repos_trace_node_locations): Mark location_revisions as const
> > > pointer.
> >
> > This might be safe. Can you search the mailing lists or somewhere and
> > see if we decided on a previous occasion that adding "const" to a
> > pointer in the public API was or was not permissible?
>
> Yeah, we did this earlier in one occasion, or I just found one such
> case. In r31271, we constify'ed revprop_table parameter for all
> functions in include/svn_client.h. The commit message says it is a fix
> for issue #3200, but i do not see any reference for this commit, or a
> discussion around this commit in this issue. The commit message can be
> found here:
>
> http://subversion.tigris.org/servlets/ReadMsg?list=svn&msgNo=36778
That's different: it was modifying an API which was unreleased (new in
1.5).
Unless we can be confident that it is a safe change, I think we should
just close this issue (as WONTFIX) because it is not an important
change, just a nicety.
(By the way, in case anyone is unclear, a "safe change" for a public
library API means source-compatible and binary-compatible.)
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-11 10:17:10 CEST