[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r31900 - in trunk/subversion: libsvn_client tests/cmdline

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: Thu, 10 Jul 2008 18:24:07 +0530

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

>>
> Well, we do return other status codes, and those will be returned from
> the call to serf_context_run, but as you found out, you shouldn't reuse
> that connection anymore. I think there are a few places where we rely on
> serf returning our particular error code. Probably that's why you found
> some of the tests failing.

Committed the fix at r32056, All tests pass now over serf.

> What you're trying to fix is how ra_serf handles invalid XML response
> bodies. While this is a bug on its own, the real reason the tests are
> failing is that the server returns invalid XML for a locations-segment
> report on a non-existant node. Attached patch fixes mod_dav_svn to
> return an empty (opening & closing tag) report in that case.

Better approach to fix this would be to change the http response status
to '404' for non-existent nodes and stub the ra (neon|serf)layers to a
svn_error_t with apr_err set to 'SVN_ERR_FS_NOT_FOUND'.

With regards
Kamesh Jayachandran
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIdgZu3WHvyO0YTCwRAvCfAKCHPnSAkuB9+vWoviDQyaUMETavDACggxEo
gFho7RJ+QTRZxuAM2Nu53GU=
=Y8D8
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-10 14:55:05 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.