On Tue, Jul 08, 2008 at 01:42:45PM -0400, Karl Fogel wrote:
> Daniel Shahaf <d.s_at_daniel.shahaf.co.il> writes:
> > Rui, Guo wrote on Tue, 8 Jul 2008 at 10:39 +0800:
> >> Please, could anybody review my patch?
> >
> > Please be patient. We all try to review patches as they come -- we all
> > were volunteers once -- but we don't have the resources to review each
> > patch as soon as it is sent. Many people have been waiting for longer
> > than you for their patches to be reviewed.
> >
> > In this case, since your patch is related to the issue-2843 branch, I
> > think you don't need to worry about finding someone to review and apply
> > the patch (which may be considered the hardest part of writing a patch!
> > :)), since Karl will likely review it as part of reviewing the branch.
> > (Not trying to throw extra work at Karl, but I understand that the patch
> > is required for further work on the branch.)
>
> Guo Rui, my apologies for the delay. I will review your patch as soon
> as I can, I'd just like to review Senthil's issue #2489 patch first (he
> is also waiting on that to continue some work). Issue #2489 required
> some special setup on my side (client certs, see the issue), so it's
> taking longer than a typical review. I hope to finish it today.
Never mind. I was a bit too anxious, I have to say. I just considered it as an
obstruction to my further development at that moment. But this is no more a
problem now: I'm busy applying visa today and tomorrow. And I can build some
more test cases while waiting for your review after come back.
One note about the patch. The patch just focused on the copy command. But the
same modification in svn_client_copy4() also apply to svn_client_move5(). I
have no time to provide a new patch now. But you can of course do it yourself
-- the modification is only one line in size.
Rui
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-09 19:57:09 CEST