[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r32023 - in trunk/subversion: include/private libsvn_subr

From: Senthil Kumaran S <senthil_at_collab.net>
Date: Tue, 08 Jul 2008 14:24:17 +0530

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

danielsh_at_tigris.org wrote:
> Author: danielsh
> Date: Mon Jul 7 12:37:58 2008
> New Revision: 32023
>
> Log:
> Follow up to r31884 with a NULL check.
>
> Patch by: kfogel
> me
>
> * subversion/libsvn_subr/simple_providers.c
> (simple_password_get): If username is NULL -- which can happen if
> someone manually edits the authn cache -- then return FALSE.
> (svn_auth__simple_first_creds_helper): Don't even try to get a password when
> we don't have a username.
>
> * subversion/include/private/svn_auth_private.h
> (svn_auth__password_get_t): Document that realmstring and username
> really ought not be NULL.

Should this follow up be backported to 1.5.x branch? since we already have
r31884 in, I feel this follow up should get in.

Thank You.
- --
Senthil Kumaran S
http://www.stylesen.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIcys29o1G+2zNQDgRAhOgAKCeGupSpYH5ZoeyeK25gTJgCHjLFgCdFqVQ
S8E2B7Kr9wXaRatekq1xD84=
=4qIl
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-08 10:55:25 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.