On Tue, Jul 08, 2008 at 11:32:41AM +0800, Rui, Guo wrote:
> > > --- branches/issue-2843-dev/subversion/libsvn_wc/copy.c (r31985)
> > > +++ branches/issue-2843-dev/subversion/libsvn_wc/copy.c (r31986)
> > > @@ -223,6 +223,7 @@ copy_added_dir_administratively(const ch
> > > SVN_ERR(svn_wc_entry(&entry, src_fullpath, src_child_dir_access,
> > > TRUE, subpool));
> > >
> > > + /* TODO(#2843) Should we skip the excluded src? */
> > > /* Recurse on directories; add files; ignore the rest. */
> > > if (this_entry.filetype == APR_DIR)
> > > {
> >
> > Hmmm. I'm not sure. If someone copies a tree T that contains excluded
> > subdir S, then when whey commit, will the new tree T_NEW (in the
> > repository) also contain S_NEW? Once we answer this question, I think
> > it will be clear how other things should behave.
> Some day I did an experiment on this. The version I used just copied the
> exclude flag to the new tree. And after commit, the server side will have a
> full source tree in the target position. I think this behavior is just fine.
> Maybe it is a good idea to maintain this behavior and make the code more
> robust?
>
After a second check on this, I find that this function is only used to copy
items added without history (In other words, those not yet in the repos). So,
this code path is irrelevant to the exclude flag.
Rui
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-08 09:09:05 CEST